inspector: fix compressed responses #61226
Open
+707
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http2
Author
|
Tagging you @legendecas because I saw some of your work on the inspector. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61226 +/- ##
========================================
Coverage 88.54% 88.55%
========================================
Files 704 704
Lines 208734 208865 +131
Branches 40271 40296 +25
========================================
+ Hits 184823 184950 +127
- Misses 15932 15948 +16
+ Partials 7979 7967 -12
🚀 New features to boost your workflow:
|
rubnogueira
changed the title
Author
|
I just removed irrelevant code, improved testing/linting, built locally Node binary, and tested against my repro. Rebased first commit message following guidelines. Please let me know if something is missing since it's my first contribution in this repo. |
legendecas
reviewed
Jan 8, 2026
Comment on lines
+167
to
+213
| async function testGzipHttp() { | ||
| await testCompressedResponse(httpServer, 'gzip', '/gzip'); | ||
| } | ||
|
|
||
| async function testGzipHttps() { | ||
| await testCompressedResponse(httpsServer, 'gzip', '/gzip'); | ||
| } | ||
|
|
||
| async function testXGzipHttp() { | ||
| await testCompressedResponse(httpServer, 'x-gzip', '/x-gzip'); | ||
| } | ||
|
|
||
| async function testXGzipHttps() { | ||
| await testCompressedResponse(httpsServer, 'x-gzip', '/x-gzip'); | ||
| } | ||
|
|
||
| async function testDeflateHttp() { | ||
| await testCompressedResponse(httpServer, 'deflate', '/deflate'); | ||
| } | ||
|
|
||
| async function testDeflateHttps() { | ||
| await testCompressedResponse(httpsServer, 'deflate', '/deflate'); | ||
| } | ||
|
|
||
| async function testBrotliHttp() { | ||
| await testCompressedResponse(httpServer, 'br', '/br'); | ||
| } | ||
|
|
||
| async function testBrotliHttps() { | ||
| await testCompressedResponse(httpsServer, 'br', '/br'); | ||
| } | ||
|
|
||
| async function testZstdHttp() { | ||
| await testCompressedResponse(httpServer, 'zstd', '/zstd'); | ||
| } | ||
|
|
||
| async function testZstdHttps() { | ||
| await testCompressedResponse(httpsServer, 'zstd', '/zstd'); | ||
| } | ||
|
|
||
| async function testPlainHttp() { | ||
| await testCompressedResponse(httpServer, null, '/plain'); | ||
| } | ||
|
|
||
| async function testPlainHttps() { | ||
| await testCompressedResponse(httpsServer, null, '/plain'); | ||
| } |
Member
There was a problem hiding this comment.
Nit: it seems like these functions can be inlined as they are just one-liner.
|
|
||
| async function testPlainHttp2Secure() { | ||
| await testCompressedResponse(http2SecureServer, null, '/plain'); | ||
| } |
Member
There was a problem hiding this comment.
Ditto, these could be inlined.
legendecas
added
commit-queue-squash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #61222
Using Chrome DevTools inspector tool, the response of the compressed requests is full of garbled symbols.
This PR implements proper compression decryption if the
content-encodingheader is returned in the response headers.Repro here: https://github.com/rubnogueira/nodejs-repro-61222